diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html
index 23acfa71..a84d2eeb 100644
--- a/debugging/book-library/index.html
+++ b/debugging/book-library/index.html
@@ -1,7 +1,7 @@
-
-
+
+
-
+ Book Library
Library
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
@@ -80,15 +83,7 @@ Library
|
-
-
- |
- |
- |
- |
- |
-
-
+
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
index 75ce6c1d..445f3577 100644
--- a/debugging/book-library/script.js
+++ b/debugging/book-library/script.js
@@ -1,17 +1,27 @@
-let myLibrary = [];
+// 1 & 3. Constant array and top-level DOM element declarations
+const myLibrary = [];
+const titleInput = document.getElementById("title");
+const authorInput = document.getElementById("author");
+const pagesInput = document.getElementById("pages");
+const readCheckbox = document.getElementById("check");
-window.addEventListener("load", function (e) {
+window.addEventListener("load", function () {
populateStorage();
- render();
+
+ const bookForm = document.getElementById("bookForm");
+ if (bookForm) {
+ bookForm.addEventListener("submit", addBook);
+ }
});
function populateStorage() {
- if (myLibrary.length == 0) {
- let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
- let book2 = new Book(
+ if (myLibrary.length === 0) {
+ // 2. Constructor called with PascalCase
+ let book1 = new LibraryBook("Robinson Crusoe", "Daniel Defoe", 252, true);
+ let book2 = new LibraryBook(
"The Old Man and the Sea",
"Ernest Hemingway",
- "127",
+ 127,
true
);
myLibrary.push(book1);
@@ -20,84 +30,87 @@ function populateStorage() {
}
}
-const title = document.getElementById("title");
-const author = document.getElementById("author");
-const pages = document.getElementById("pages");
-const check = document.getElementById("check");
-
-//check the right input from forms and if its ok -> add the new book (object in array)
-//via Book function and start render function
-function submit() {
- if (
- title.value == null ||
- title.value == "" ||
- pages.value == null ||
- pages.value == ""
- ) {
- alert("Please fill all fields!");
- return false;
- } else {
- let book = new Book(title.value, title.value, pages.value, check.checked);
- library.push(book);
- render();
+function addBook(e) {
+ e.preventDefault();
+
+ // 4. Input preprocessing and consistent usage of cleaned values
+ const cleanTitle = titleInput.value.trim();
+ const cleanAuthor = authorInput.value.trim();
+ const cleanPages = parseInt(pagesInput.value, 10);
+
+ if (!cleanTitle || !cleanAuthor || isNaN(cleanPages) || cleanPages < 1) {
+ alert("Please provide a valid title, author, and positive page count!");
+ return;
}
+
+ const newBook = new LibraryBook(
+ cleanTitle,
+ cleanAuthor,
+ cleanPages,
+ readCheckbox.checked
+ );
+
+ myLibrary.push(newBook);
+ document.getElementById("bookForm").reset();
+ render();
}
-function Book(title, author, pages, check) {
+// 2. PascalCase constructor function
+function LibraryBook(title, author, pages, isRead) {
this.title = title;
this.author = author;
this.pages = pages;
- this.check = check;
+ this.isRead = isRead;
}
function render() {
- let table = document.getElementById("display");
- let rowsNumber = table.rows.length;
- //delete old table
- for (let n = rowsNumber - 1; n > 0; n-- {
- table.deleteRow(n);
- }
- //insert updated row and cells
- let length = myLibrary.length;
- for (let i = 0; i < length; i++) {
- let row = table.insertRow(1);
- let titleCell = row.insertCell(0);
- let authorCell = row.insertCell(1);
- let pagesCell = row.insertCell(2);
- let wasReadCell = row.insertCell(3);
- let deleteCell = row.insertCell(4);
- titleCell.innerHTML = myLibrary[i].title;
- authorCell.innerHTML = myLibrary[i].author;
- pagesCell.innerHTML = myLibrary[i].pages;
-
- //add and wait for action for read/unread button
- let changeBut = document.createElement("button");
- changeBut.id = i;
- changeBut.className = "btn btn-success";
- wasReadCell.appendChild(changeBut);
- let readStatus = "";
- if (myLibrary[i].check == false) {
- readStatus = "Yes";
- } else {
- readStatus = "No";
- }
- changeBut.innerText = readStatus;
-
- changeBut.addEventListener("click", function () {
- myLibrary[i].check = !myLibrary[i].check;
+ // 5. Efficient single-operation clearing of
+ const tableBody = document.querySelector("#display tbody");
+ tableBody.textContent = "";
+
+ const libraryLength = myLibrary.length;
+ for (let i = 0; i < libraryLength; i++) {
+ const row = tableBody.insertRow();
+ const titleCell = row.insertCell(0);
+ const authorCell = row.insertCell(1);
+ const pagesCell = row.insertCell(2);
+ const readStatusCell = row.insertCell(3);
+ const deleteCell = row.insertCell(4);
+
+ titleCell.textContent = myLibrary[i].title;
+ authorCell.textContent = myLibrary[i].author;
+ pagesCell.textContent = myLibrary[i].pages;
+
+ // Read status toggle button
+ const toggleReadBtn = document.createElement("button");
+ // 6. No unnecessary ID attribute assignment
+ toggleReadBtn.className = "btn btn-success";
+ toggleReadBtn.textContent = myLibrary[i].isRead ? "Yes" : "No";
+
+ toggleReadBtn.addEventListener("click", function () {
+ myLibrary[i].isRead = !myLibrary[i].isRead;
render();
});
+ readStatusCell.appendChild(toggleReadBtn);
+
+ // Delete button
+ const deleteBtn = document.createElement("button");
+ // 6. No unnecessary ID attribute assignment
+ deleteBtn.className = "btn btn-warning";
+ deleteBtn.textContent = "Delete";
- //add delete button to every row and render again
- let delButton = document.createElement("button");
- delBut.id = i + 5;
- deleteCell.appendChild(delBut);
- delBut.className = "btn btn-warning";
- delBut.innerHTML = "Delete";
- delBut.addEventListener("clicks", function () {
- alert(`You've deleted title: ${myLibrary[i].title}`);
+ deleteBtn.addEventListener("click", function () {
+ const deletedTitle = myLibrary[i].title;
+
+ // 7. Delete from array and re-render DOM BEFORE triggering the alert
myLibrary.splice(i, 1);
render();
+
+ // Defer alert so the browser completes its UI repaint first
+ setTimeout(() => {
+ alert(`You've deleted title: ${deletedTitle}`);
+ }, 0);
});
+ deleteCell.appendChild(deleteBtn);
}
}
diff --git a/debugging/book-library/style.css b/debugging/book-library/style.css
index 302950cb..4e85e5af 100644
--- a/debugging/book-library/style.css
+++ b/debugging/book-library/style.css
@@ -1,17 +1,7 @@
-.form-group {
- width: 400px;
- height: 300px;
- align-self: left;
+#bookForm {
+ max-width: 400px;
padding-left: 20px;
-}
-
-.btn {
- display: block;
-}
-
-.form-check-label {
- padding-left: 20px;
- margin: 5px 0px 5px 0px;
+ margin-bottom: 20px;
}
button.btn-info {